/
ComplexInterfaceSpec.kt
240 lines (209 loc) · 7.41 KB
/
ComplexInterfaceSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
package io.gitlab.arturbosch.detekt.rules.complexity
import io.gitlab.arturbosch.detekt.test.TestConfig
import io.gitlab.arturbosch.detekt.test.compileAndLint
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
private const val THRESHOLD = 4
private val defaultConfigMap = mapOf("threshold" to THRESHOLD)
private val staticDeclarationsConfig = TestConfig(
defaultConfigMap + ("includeStaticDeclarations" to true)
)
private val privateDeclarationsConfig = TestConfig(
defaultConfigMap + ("includePrivateDeclarations" to true)
)
private val ignoreOverloadedConfig = TestConfig(
defaultConfigMap + ("ignoreOverloaded" to true)
)
class ComplexInterfaceSpec {
private val subject = ComplexInterface(TestConfig(defaultConfigMap))
@Nested
inner class `ComplexInterface rule positives` {
@Nested
inner class `interface members` {
val code = """
interface I {
fun f1()
fun f2()
val i1: Int
fun fImpl() {}
}
"""
@Test
fun `reports complex interface`() {
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports complex interface with includeStaticDeclarations config`() {
val rule = ComplexInterface(staticDeclarationsConfig)
assertThat(rule.compileAndLint(code)).hasSize(1)
}
}
@Nested
inner class `nested interface members` {
val code = """
class I {
interface Nested {
fun f1()
fun f2()
val i1: Int
fun fImpl() {}
}
}
"""
@Test
fun `reports complex interface`() {
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports complex interface with includeStaticDeclarations config`() {
val rule = ComplexInterface(staticDeclarationsConfig)
assertThat(rule.compileAndLint(code)).hasSize(1)
}
}
@Nested
inner class `interface with static declarations` {
val code = """
interface I {
fun f1()
companion object {
fun sf() = 0
const val c = 0
val v = 0
}
}
"""
@Test
fun `does not report static declarations per default`() {
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `reports complex interface with includeStaticDeclarations config`() {
val rule = ComplexInterface(staticDeclarationsConfig)
assertThat(rule.compileAndLint(code)).hasSize(1)
}
}
@Nested
inner class `private functions` {
val code = """
interface I {
fun f1()
fun f2()
val i1: Int
private fun fImpl() {}
}
"""
@Test
fun `does not report complex interface`() {
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does report complex interface with includePrivateDeclarations config`() {
val rule = ComplexInterface(privateDeclarationsConfig)
assertThat(rule.compileAndLint(code)).hasSize(1)
}
}
@Nested
inner class `private members` {
val code = """
interface I {
fun f1()
fun f2()
private val i1: Int
get() = 42
fun fImpl() {}
}
"""
@Test
fun `does not report complex interface`() {
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does report complex interface with includePrivateDeclarations config`() {
val rule = ComplexInterface(privateDeclarationsConfig)
assertThat(rule.compileAndLint(code)).hasSize(1)
}
}
@Nested
inner class `overloaded methods` {
val code = """
interface I {
fun f1()
fun f1(i: Int)
val i1: Int
fun fImpl() {}
}
"""
@Test
fun `reports complex interface with overloaded methods`() {
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `does not report simple interface with ignoreOverloaded`() {
val rule = ComplexInterface(ignoreOverloadedConfig)
assertThat(rule.compileAndLint(code)).isEmpty()
}
@Test
fun `reports complex interface with extension methods with a different receiver`() {
val interfaceWithExtension = """
interface I {
fun f1()
fun String.f1(i: Int)
val i1: Int
fun fImpl() {}
}
"""
val rule = ComplexInterface(ignoreOverloadedConfig)
assertThat(rule.compileAndLint(interfaceWithExtension)).hasSize(1)
}
@Test
fun `does not report simple interface with extension methods with the same receiver`() {
val interfaceWithOverloadedExtensions = """
interface I {
fun String.f1()
fun String.f1(i: Int)
val i1: Int
fun fImpl() {}
}
"""
val rule = ComplexInterface(ignoreOverloadedConfig)
assertThat(rule.compileAndLint(interfaceWithOverloadedExtensions)).isEmpty()
}
}
}
@Nested
inner class `ComplexInterface rule negatives` {
@Test
fun `does not report a simple interface `() {
val code = """
interface I {
fun f()
fun fImpl() {
val x = 0 // should not report
}
val i: Int
// a comment shouldn't be detected
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report a simple interface with a companion object`() {
val code = """
interface I {
fun f()
companion object {
fun sf() = 0
const val c = 0
}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report an empty interface`() {
val code = "interface Empty"
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
}