/
AlsoCouldBeApplySpec.kt
153 lines (136 loc) · 3.89 KB
/
AlsoCouldBeApplySpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
package io.gitlab.arturbosch.detekt.rules.style
import io.gitlab.arturbosch.detekt.api.Config
import io.gitlab.arturbosch.detekt.test.assertThat
import io.gitlab.arturbosch.detekt.test.compileAndLint
import org.junit.jupiter.api.Test
class AlsoCouldBeApplySpec {
val subject = AlsoCouldBeApply(Config.empty)
@Test
fun `does not report when no also is used`() {
val code = """
fun f(a: Int) {
a.let {
it.plus(5)
it.minus(10)
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `reports an also where only it is used in block`() {
val code = """
fun f(a: Int) {
a.also {
it.plus(5)
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `report is focused on also keyword`() {
val code = """
fun f(a: Int) {
a.also {
it.plus(5)
}
}
""".trimIndent()
val findings = subject.compileAndLint(code)
assertThat(findings).hasSize(1)
assertThat(findings).hasStartSourceLocation(2, 7)
assertThat(findings).hasEndSourceLocation(2, 11)
}
@Test
fun `reports an also on nullable type`() {
val code = """
fun f(a: Int?) {
a?.also {
it.plus(5)
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports an also with lambda passed as Argument in parenthesis`() {
val code = """
fun f(a: Int?) {
a?.also({
it.plus(5)
})
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `does not report if it is not used in also`() {
val code = """
fun f(a: Int?, b: Int) {
a?.also {
b.plus(5)
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report if it is renamed`() {
val code = """
fun f(x: Int, y: Int) {
x.also { named ->
named.plus(5)
named.minus(y)
}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does report if it is on one line separated by semicolon`() {
val code = """
fun f(a: Int) {
a.also { it.plus(5); it.minus(10) }
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `detect violation in also nested in also`() {
val code = """
fun f(a: Int) {
a.also { x -> x.also { it.plus(10) } }
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `does not report when all statements are not 'it'-started expressions`() {
val code = """
fun test(foo: Foo) {
foo.also {
it.bar()
println(it)
it.baz()
}
}
class Foo {
fun bar() {}
fun baz() {}
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report when no statements`() {
val code = """
fun test(foo: Foo) {
foo.also {
}
}
class Foo
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
}