-
-
Notifications
You must be signed in to change notification settings - Fork 758
/
UnnecessaryBracesAroundTrailingLambdaSpec.kt
242 lines (209 loc) · 7.31 KB
/
UnnecessaryBracesAroundTrailingLambdaSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
package io.gitlab.arturbosch.detekt.rules.style.movelambdaout
import io.gitlab.arturbosch.detekt.api.Config
import io.gitlab.arturbosch.detekt.rules.KotlinCoreEnvironmentTest
import io.gitlab.arturbosch.detekt.test.assertThat
import io.gitlab.arturbosch.detekt.test.compileAndLintWithContext
import io.gitlab.arturbosch.detekt.test.lintWithContext
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
import org.junit.jupiter.api.Test
// Source https://github.com/JetBrains/intellij-community/tree/master/plugins/kotlin/idea/tests/testData/inspectionsLocal/moveLambdaOutsideParentheses
@KotlinCoreEnvironmentTest
class UnnecessaryBracesAroundTrailingLambdaSpec(val env: KotlinCoreEnvironment) {
private val subject = UnnecessaryBracesAroundTrailingLambda(Config.empty)
@Test
fun `does report when trailing lambda had braces`() {
val code = """
fun foo() {
bar({ it })
}
fun bar(a: Int = 0, f: (Int) -> Int) { }
fun bar(a: Int, b: Int, f: (Int) -> Int) { }
""".trimIndent()
val findings = subject.lintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does not report when lambda inside braces is used in class delegation`() {
val code = """
interface I
class C1(s: String, f: (String) -> String) : I
class C2 : I by C1("", { "" })
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does report when lambda inside braces is used for function param`() {
val code = """
fun foo(p: (Int, () -> Int) -> Unit) {
p(1, { 2 })
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does not report when trailing lambda is used without braces`() {
val code = """
fun foo() {
bar() { it }
}
fun bar(b: (Int) -> Int) {
b(1)
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when first and second lambda is present`() {
val code = """
fun foo() {
bar({ it }) { it }
}
fun bar(p1: (Int) -> Int, p2: (Int) -> Int) {}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when removing braces changes the code`() {
val code = """
fun test(a: (String) -> Unit = {}, b: (String) -> Unit = {}) {
a("a")
b("b")
}
fun foo() {
test({ })
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report when second lambda can be moved out of the braces`() {
val code = """
fun test(a: (String) -> Unit = {}, b: (String) -> Unit = {}) {
a("a")
b("b")
}
fun foo() {
test({ }, { }) // Don't flag it as IDE also doesn't flag it and trailing lambda might look more complicated in this case
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does not report first lambda can not be moved out of the braces`() {
val code = """
fun foo() {
bar({ it })
}
fun bar(b: (Int) -> Int, option: Int = 0) {}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does report second lambda with label can not be moved out of the braces`() {
val code = """
fun foo() {
bar(2, l@{ it })
}
fun bar(a: Int, b: (Int) -> Int) {
b(a)
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does report lambda with multiline expression can not be moved out of the braces`() {
val code = """
fun foo() {
bar(2, {
val x = 3
it * x
})
}
fun bar(a: Int, b: (Int) -> Int) {
b(a)
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1).hasStartSourceLocation(2, 5).hasEndSourceLocation(2, 8)
}
@Test
fun `does not report lambda with label which can be moved out of the braces`() {
val code = """
fun foo() {
bar(name1 = 3, name2 = 2, name3 = 1, name4 = { it })
}
fun bar(name1: Int, name2: Int, name3: Int, name4: (Int) -> Int): Int {
return name4(name1) + name2 + name3
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
@Test
fun `does report when lambda returned from fun can have trailing lambda`() {
val code = """
fun bar() {
foo { "one" } ({ "two" })
}
fun foo(a: () -> String): (() -> String) -> Unit {
return { }
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does report when suspend lambda inside braces`() {
val code = """
fun runSuspend(block: suspend () -> Unit) {}
fun println() {}
fun usage() {
runSuspend({ println() })
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does not report when suspend lambda inside braces`() {
val code = """
fun runSuspend(block: suspend () -> Unit) {}
fun println() {}
fun usage() {
runSuspend({ println() })
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does report generic param lambda has braces around it`() {
val code = """
fun <T> foo(t: T) {}
fun test() {
foo({ "a" })
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).hasSize(1)
}
@Test
fun `does not report when last parameter is vararg - #6593`() {
val code = """
fun foo(f: () -> Unit, vararg x: Unit) = f()
fun test() {
foo({})
}
""".trimIndent()
val findings = subject.compileAndLintWithContext(env, code)
assertThat(findings).isEmpty()
}
}