From 1a60429dd7ca77b13bcf40aa67d42cedd5951656 Mon Sep 17 00:00:00 2001 From: Toshiaki Kameyama Date: Tue, 30 Aug 2022 00:40:14 +0900 Subject: [PATCH] UnusedPrivateMember: fix false positive with backtick parameters (#5252) --- .../detekt/rules/style/UnusedPrivateMember.kt | 2 +- .../detekt/rules/style/UnusedPrivateMemberSpec.kt | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt b/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt index 9180de718ad..eaf21701784 100644 --- a/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt +++ b/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt @@ -258,7 +258,7 @@ private class UnusedParameterVisitor(allowedNames: Regex) : UnusedMemberVisitor( } override fun visitReferenceExpression(expression: KtReferenceExpression) { - parameters.remove(expression.text) + parameters.remove(expression.text.removeSurrounding("`")) super.visitReferenceExpression(expression) } }) diff --git a/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt b/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt index f7e39e0cb5d..145541479fb 100644 --- a/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt +++ b/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt @@ -1468,6 +1468,17 @@ class UnusedPrivateMemberSpec(val env: KotlinCoreEnvironment) { } } + @Nested + inner class `backtick identifiers - #5251` { + @Test + fun `does not report used backtick parameters`() { + val code = """ + fun test(`foo bar`: Int) = `foo bar` + """ + assertThat(subject.compileAndLintWithContext(env, code)).isEmpty() + } + } + @Nested inner class `list get overloaded operator function - #3640` { @Test