From 24f1b8339e00d14f471e54d45c18b8eaed5058fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Brais=20Gab=C3=ADn?= Date: Sun, 7 Aug 2022 23:08:54 +0200 Subject: [PATCH] Improve tests in UnnecessaryParenthesesSpec (#5197) --- .../rules/style/UnnecessaryParenthesesSpec.kt | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt b/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt index a42d9a874f3..5711bc21000 100644 --- a/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt +++ b/detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt @@ -3,8 +3,11 @@ package io.gitlab.arturbosch.detekt.rules.style import io.gitlab.arturbosch.detekt.test.TestConfig import io.gitlab.arturbosch.detekt.test.lint import org.assertj.core.api.Assertions.assertThat +import org.junit.jupiter.api.Named import org.junit.jupiter.params.ParameterizedTest +import org.junit.jupiter.params.provider.Arguments import org.junit.jupiter.params.provider.MethodSource +import java.util.stream.Stream class UnnecessaryParenthesesSpec { @ParameterizedTest @@ -332,15 +335,19 @@ class UnnecessaryParenthesesSpec { companion object { class RuleTestCase(val allowForUnclearPrecedence: Boolean) { val rule = UnnecessaryParentheses( - TestConfig(mapOf("allowForUnclearPrecedence" to allowForUnclearPrecedence)) + TestConfig("allowForUnclearPrecedence" to allowForUnclearPrecedence) ) } @JvmStatic - fun cases(): List { - return listOf( - RuleTestCase(allowForUnclearPrecedence = false), - RuleTestCase(allowForUnclearPrecedence = true), + fun cases(): Stream { + return Stream.of( + Arguments.of( + Named.of("Without allow for unclear precedence", RuleTestCase(allowForUnclearPrecedence = false)) + ), + Arguments.of( + Named.of("With allow for unclear precedence", RuleTestCase(allowForUnclearPrecedence = true)) + ), ) } }