From fe03b6dd2651520c73c33a0dfffcd96849734cb2 Mon Sep 17 00:00:00 2001
From: "Vitaly V. Pinchuk" <vetal.978@gmail.com>
Date: Wed, 1 Jun 2022 21:07:44 +0300
Subject: [PATCH] Improve exception message (#4823)

* Improve exception message

Report detailed location of an error.

* Add test case

* Split tests

* Improve error location message presentation
---
 .../gitlab/arturbosch/detekt/core/Analyzer.kt |  1 +
 .../arturbosch/detekt/core/AnalyzerSpec.kt    | 54 +++++++++++++++++++
 .../configs/config-value-type-correct.yml     |  4 ++
 3 files changed, 59 insertions(+)

diff --git a/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt b/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt
index ea0641521fb..3d68a3f2f41 100644
--- a/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt
+++ b/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt
@@ -155,6 +155,7 @@ private fun MutableMap<String, List<Finding>>.mergeSmells(other: Map<String, Lis
 private fun throwIllegalStateException(file: KtFile, error: Throwable): Nothing {
     val message = """
     Analyzing ${file.absolutePath()} led to an exception. 
+    Location: ${error.stackTrace.firstOrNull()?.toString()}
     The original exception message was: ${error.localizedMessage}
     Running detekt '${whichDetekt() ?: "unknown"}' on Java '${whichJava()}' on OS '${whichOS()}'
     If the exception message does not help, please feel free to create an issue on our GitHub page.
diff --git a/detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/AnalyzerSpec.kt b/detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/AnalyzerSpec.kt
index df4c53566dd..79ba0e0c051 100644
--- a/detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/AnalyzerSpec.kt
+++ b/detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/AnalyzerSpec.kt
@@ -86,6 +86,34 @@ class AnalyzerSpec {
 
             assertThat(settings.use { analyzer.run(listOf(compileForTest(testFile))) }).isEmpty()
         }
+
+        @Test
+        fun `with faulty rule`() {
+            val testFile = path.resolve("Test.kt")
+            val settings = createProcessingSettings(
+                testFile,
+                yamlConfig("configs/config-value-type-correct.yml")
+            )
+            val analyzer = Analyzer(settings, listOf(FaultyRuleSetProvider()), emptyList())
+
+            assertThatThrownBy { settings.use { analyzer.run(listOf(compileForTest(testFile))) } }
+                .hasCauseInstanceOf(IllegalStateException::class.java)
+                .hasMessageContaining("Location: ${FaultyRule::class.java.name}")
+        }
+
+        @Test
+        fun `with faulty rule without stack trace`() {
+            val testFile = path.resolve("Test.kt")
+            val settings = createProcessingSettings(
+                testFile,
+                yamlConfig("configs/config-value-type-correct.yml")
+            )
+            val analyzer = Analyzer(settings, listOf(FaultyRuleNoStackTraceSetProvider()), emptyList())
+
+            assertThatThrownBy { settings.use { analyzer.run(listOf(compileForTest(testFile))) } }
+                .hasCauseInstanceOf(IllegalStateException::class.java)
+                .hasMessageContaining("Location: ${null}")
+        }
     }
 }
 
@@ -106,3 +134,29 @@ private class MaxLineLength(config: Config, threshold: Int?) : Rule(config) {
         }
     }
 }
+
+private class FaultyRuleSetProvider : RuleSetProvider {
+    override val ruleSetId: String = "style"
+    override fun instance(config: Config) = RuleSet(ruleSetId, listOf(FaultyRule(config)))
+}
+
+private class FaultyRule(config: Config) : Rule(config) {
+    override val issue = Issue(this::class.java.simpleName, Severity.Style, "", Debt.FIVE_MINS)
+    override fun visitKtFile(file: KtFile) {
+        throw object : IllegalStateException("Deliberately triggered error.") {}
+    }
+}
+
+private class FaultyRuleNoStackTraceSetProvider : RuleSetProvider {
+    override val ruleSetId: String = "style"
+    override fun instance(config: Config) = RuleSet(ruleSetId, listOf(FaultyRuleNoStackTrace(config)))
+}
+
+private class FaultyRuleNoStackTrace(config: Config) : Rule(config) {
+    override val issue = Issue(this::class.java.simpleName, Severity.Style, "", Debt.FIVE_MINS)
+    override fun visitKtFile(file: KtFile) {
+        throw object : IllegalStateException("Deliberately triggered error without stack trace.") {
+            init { stackTrace = emptyArray() }
+        }
+    }
+}
diff --git a/detekt-core/src/test/resources/configs/config-value-type-correct.yml b/detekt-core/src/test/resources/configs/config-value-type-correct.yml
index a3109a61d11..b512e9f819d 100644
--- a/detekt-core/src/test/resources/configs/config-value-type-correct.yml
+++ b/detekt-core/src/test/resources/configs/config-value-type-correct.yml
@@ -2,3 +2,7 @@ style:
   MaxLineLength:
     active: true
     maxLineLength: 120
+  FaultyRule:
+    active: true
+  FaultyRuleNoStackTrace:
+    active: true