Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dynamic --jvm-target values when using --help flag #4694

Merged
merged 1 commit into from Apr 7, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented Apr 7, 2022

This will now print values supported by the embedded Kotlin version and won't have to be updated manually anymore.

The required toString override was introduced in Kotlin 1.6.20 thanks to my first PR on jetbrains/kotlin :)

Before:

    --jvm-target
      EXPERIMENTAL: Target version of the generated JVM bytecode that was 
      generated during compilation and is now being used for type resolution 
      (1.6, 1.8, 9, 10, 11, 12, 13, 14, 15, 16 or 17)
      Default: 1.8

After:

    --jvm-target
      EXPERIMENTAL: Target version of the generated JVM bytecode that was 
      generated during compilation and is now being used for type resolution
      Default: 1.8
      Possible Values: [1.6, 1.8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18]

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #4694 (7f86eb9) into main (ed8b089) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #4694      +/-   ##
============================================
- Coverage     84.45%   84.44%   -0.02%     
  Complexity     3436     3436              
============================================
  Files           492      492              
  Lines         11335    11337       +2     
  Branches       2082     2083       +1     
============================================
  Hits           9573     9573              
- Misses          701      703       +2     
  Partials       1061     1061              
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 69.23% <0.00%> (-5.77%) ⬇️
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <100.00%> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 88.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8b089...7f86eb9. Read the comment docs.

@3flex 3flex marked this pull request as draft April 7, 2022 04:49
This will now print values supported by the embedded Kotlin version and
won't have to be updated manually anymore.
@3flex 3flex marked this pull request as ready for review April 7, 2022 05:56
@cortinico cortinico added this to the 1.20.0 milestone Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants