UnnecessaryParentheses false positive with in and ?:

[Gama11]

The following snippet triggers the UnnecessaryParentheses rule:

try {
} catch (e: Exception) {
    if ("foo" in (e.message ?: "")) {}
}

However, they're not in fact unnecessary:

Your Environment

• Version of detekt used: 1.21.0
• Version of Gradle used (if applicable): 7.5
• Operating System and version: Windows 10 (19044.1766)

[BraisGabin]

I can reproduce it with this unit test:

    @ParameterizedTest
    @MethodSource("cases")
    fun `with unnecessary parentheses on aval assignment`(testCase: RuleTestCase) {
        val code = """val a = if ("foo" in (null ?: "")) 1 else 2"""

        assertThat(testCase.rule.lint(code)).hasSize(0)
    }

But the issue seems to be in KtPsiUtil.areParenthesesUseless. I imagine that this will be solved in the compiler and we will be able to use the fix. But I'm not sure where to report this to be sure that this is fixed.

#4881 would be used as a workaround to this issue if you enable allowForUnclearPrecedence. But that's not released yet and as I said, it's just a workaround.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

[BraisGabin]

This is still an issue right now. But I feel that there is no way to do something about it. Any idea is more than welcome.

But, because this is not actionable, I'm closing it.