Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComplexInterface: do not count method overloads #5165

Closed
pinguinjkeke opened this issue Aug 1, 2022 · 2 comments · Fixed by #5173
Closed

ComplexInterface: do not count method overloads #5165

pinguinjkeke opened this issue Aug 1, 2022 · 2 comments · Fixed by #5173
Assignees
Labels
good first issue Issue that is easy to pickup for people that are new to the project help wanted improvement rules

Comments

@pinguinjkeke
Copy link
Contributor

The rule or changes you're looking for might have already been suggested!
Please search in the issues before creating a new one.

Expected Behavior of the rule

It will be nice if ComplexInterface rule will have a skipOverloadMethods option.

If the option is on, it will count overloaded methods as 1.

@cortinico
Copy link
Member

Makes sense. I would probably call the parameter ignoreOverridden to be consistent with other rules

@cortinico cortinico added help wanted good first issue Issue that is easy to pickup for people that are new to the project labels Aug 1, 2022
@pt2121
Copy link
Contributor

pt2121 commented Aug 3, 2022

Can I take a stab at this?

schalkms pushed a commit that referenced this issue Aug 5, 2022
) (#5173)

* Allow to ignore overloaded methods for complex interface rule (#5165)

* Fix name shadowing in complex interface tests

* Generate documentation for ignoreOverloaded in complex interface

Co-authored-by: Prat T <pt2121@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that is easy to pickup for people that are new to the project help wanted improvement rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants