Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndOfSentenceFormat highlights everything #5310

Closed
TWiStErRob opened this issue Sep 18, 2022 · 2 comments · Fixed by #5311
Closed

EndOfSentenceFormat highlights everything #5310

TWiStErRob opened this issue Sep 18, 2022 · 2 comments · Fixed by #5311
Labels

Comments

@TWiStErRob
Copy link
Member

Expected Behavior

The highlighted character is wrong (blue)
image

Observed Behavior

image

Steps to Reproduce

Copy code from https://github.com/detekt/detekt/blob/main/detekt-rules-documentation/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/documentation/EndOfSentenceFormatSpec.kt to the IDE and configure Detekt with EndOfSentenceFormat.

Context

Enabling all rules of Detekt on yet another project and reporting back.

Your Environment

  • Version of detekt used: 1.21.0
@TWiStErRob
Copy link
Member Author

Submitted PR too: #5311

(for future reference: for "trivial" fixes like this, do I need issues? or can the above description go straight to the PR?)

@schalkms
Copy link
Member

In this repo, no strict rule exists regarding this. In any case, documenting the problem helps to refer to it in the future.

for future reference: for "trivial" fixes like this, do I need issues? or can the above description go straight to the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants