New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrappers for new rules in ktlint 0.48 #5627
Comments
RE To this: I believe we should add those wrappers. The reason is that we've been doing that in the past to keep feature parity between bare Ktlint and our wrapper. We do already have other rules between first-party & our ktlint wrapper that have overlapping features. I won't diverge now |
This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days. |
Hi @cortinico / @3flex so do we want to add the wrapper or not for these new rules? |
As mentioned above, I think we should add wrapper for all the rules |
It's up for grabs @atulgpt if you want to work on it? |
Sure. Will this conflict with #6028? Or should I create a PR against your branch? |
Yes, it will conflict. I've just pushed the last changes for that PR and don't expect to make any more, so it should be safe to work off that branch until it's merged. |
Hi, @3flex I have created a Although I have a few queries, 1. We already have cc @cortinico |
Expected Behavior of the rule
I can enable the following ktlint rules:
Context
We have wrappers for other ktlint rules. We should add wrappers for the rules added in ktlint 0.48.0 (see #5625).
The text was updated successfully, but these errors were encountered: