Add option to add a reason to ForbiddenMethodCall
#4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4910 +/- ##
============================================
- Coverage 84.92% 84.91% -0.01%
- Complexity 3605 3614 +9
============================================
Files 502 502
Lines 11873 11887 +14
Branches 2227 2237 +10
============================================
+ Hits 10083 10094 +11
+ Misses 691 690 -1
- Partials 1099 1103 +4
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jul 20, 2022
...t-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenMethodCall.kt
Outdated
Show resolved
Hide resolved
|
How Do we go about breaking changes in minor releases? Do we need an upgrade gradle task for users to call? |
marschwar
approved these changes
Jul 20, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...les-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenMethodCallSpec.kt
Fixed
Show fixed
Hide fixed
...les-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenMethodCallSpec.kt
Fixed
Show fixed
Hide fixed
…/rules/style/ForbiddenMethodCall.kt Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
VitalyVPinchuk
pushed a commit
to VitalyVPinchuk/detekt
that referenced
this pull request
Jul 25, 2022
* Improve tests * Improve issue message * Removes that test support with comma-separated strings * Add support for reasons in ForbiddenMethodCall * Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenMethodCall.kt Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com> Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #4909 but now adding it to
ForbiddenMethodCallImportant: This introduces a breaking change in
ForbiddenMethodCall. It no longer allows comma-separated imports as a String. It should use yml lists. I'm targetting this to1.22.0because on1.21.0we added make that all those usages will be a warning. Tell me is we should be more conservative.The reason that this is a draft is just to avoid accidental merges. But the code should be ready to merge.
Related with #3501