Assert end source locations #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marschwar
approved these changes
Jul 23, 2022
| @@ -6,7 +6,7 @@ import io.gitlab.arturbosch.detekt.api.TextLocation | |||
| import org.assertj.core.api.AbstractAssert | |||
| import org.assertj.core.api.AbstractListAssert | |||
| import org.assertj.core.util.CheckReturnValue | |||
| import java.util.Objects | |||
| import java.util.* | |||
There was a problem hiding this comment.
I did not even realize that we allow wildcard imports. I would have expected that some check would have failed
There was a problem hiding this comment.
our current configuration:
WildcardImport:
active: true
excludes: ['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**']
excludeImports:
- 'java.util.*'This case hit both excludes. I'm going to change this for us.
BraisGabin
force-pushed
the
assert-end-source-locations
branch
from
78ddade
to
6245074
Compare
Codecov Report
@@ Coverage Diff @@
## main #5116 +/- ##
=========================================
Coverage 84.91% 84.91%
Complexity 3614 3614
=========================================
Files 502 502
Lines 11887 11887
Branches 2237 2237
=========================================
Hits 10094 10094
Misses 690 690
Partials 1103 1103 Continue to review full report at Codecov.
|
VitalyVPinchuk
pushed a commit
to VitalyVPinchuk/detekt
that referenced
this pull request
Jul 25, 2022
* Add option to assert end source locations * Don't use hasSourceLocations * Don't use hasSourceLocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this refactor to finish: #5058
The idea behind this PR is in the comment: https://github.com/detekt/detekt/pull/5058/files#r927045468
All the changes made outside
FindingsAssertions.ktwhere done using the "fix deprecation" feature.