Make ArrayPrimitive rule honor the RequiresTypeResolution annotation #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
array-primitive-truly-requires-type-resolution
branch
from
ad311fd
to
d8e447f
Compare
BraisGabin
force-pushed
the
array-primitive-truly-requires-type-resolution
branch
from
d8e447f
to
497b067
Compare
Codecov Report
@@ Coverage Diff @@
## main #5175 +/- ##
============================================
- Coverage 84.97% 84.95% -0.02%
Complexity 3638 3638
============================================
Files 502 502
Lines 11971 11974 +3
Branches 2258 2258
============================================
+ Hits 10172 10173 +1
Misses 689 689
- Partials 1110 1112 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schalkms
approved these changes
Aug 4, 2022
cortinico
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue detected on #5130 related with the rule
ArrayPrimitive. Right now it says that it requires type resolution but that's not 100% true. It also detects som issues without it. To honor the annotation this rule will not report those issues without type resolution anymore.