Make detekt less noisy #5448
Merged
Make detekt less noisy #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
Oct 19, 2022
Comment on lines
+34
to
+37
| @Deprecated( | ||
| "You should pass a printStream", | ||
| ReplaceWith("createKotlinCoreEnvironment(configuration, disposable, System.err)") | ||
| ) |
There was a problem hiding this comment.
printStream: PrintStream = System.err,
wouldn't work?
There was a problem hiding this comment.
It would. But that would break binary compatibility.
And I'm not a big fan of the default values, too be honest.
There was a problem hiding this comment.
agreed there, but when there's two other default values already :)
a @jvmoverloads would help with binary compat I think, and one less method, and one less deprecation warning to action for users.
TWiStErRob
approved these changes
Oct 19, 2022
schalkms
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5436 (at least the regression part)