Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attribute class #14

Open
tunnckoCore opened this issue Sep 11, 2017 · 1 comment
Open

Add Attribute class #14

tunnckoCore opened this issue Sep 11, 2017 · 1 comment

Comments

@tunnckoCore
Copy link

One more thing is to add Attribute, which should not inherit from Node, so this would be enough

class Attribute {
  constructor (name, value, ns) {
    this.nodeType = 2
    this.name = name
    this.value = value
    this.namespaceURI = ns
  }
}

I can PR with fixes and updates addressed in couple of issues, do you want such PR?

@developit
Copy link
Owner

This one is probably too strict for undom - we have to err on the side of minimalism. There are a bunch of nice spec-compliant DOM implementations out there, undom's value is in being tiny (and therein sometimes less compliant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants