Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Plain icons return 403 #2148

Open
1 task done
jeremygau opened this issue Feb 15, 2024 · 7 comments
Open
1 task done

[BUG]: Plain icons return 403 #2148

jeremygau opened this issue Feb 15, 2024 · 7 comments
Labels
bug Use this label for pointing out bugs priority: high

Comments

@jeremygau
Copy link

I have searched through the issues and didn't find my problem.

  • Confirm

Bug description

I'm using the https://cdn.jsdelivr.net/gh/devicons/devicon@latest/icons/devicon/devicon-plain.svg like urls
But some return 403

Some are :

  • react
  • spring
  • tailwind
  • mysql
  • vault
  • nginx

Possible fixes or solutions

Create plain icons for these icons

Additional information

No response

@jeremygau jeremygau added the bug Use this label for pointing out bugs label Feb 15, 2024
BalaM314 added a commit to BalaM314/balam314.github.io that referenced this issue Feb 16, 2024
@BalaM314
Copy link

Same issue
There are probably many sites relying on this repo for images, and that commit just broke all of them with no warning
please add back the -plain icons

@Snailedlt
Copy link
Collaborator

Hi there, thank you for reporting this!
This was not intended, and not expected, especially for icons like react, where the icon itself hasn't been removed or changed. It seems like something might have gone wrong with some aliases in the latest release.

@lunatic-fox do you have time to take a look at this ASAP?

@Panquesito7
Copy link
Member

I'm using the https://cdn.jsdelivr.net/gh/devicons/devicon@latest/icons/devicon/devicon-plain.svg like urls

I'm kind of confused now. 🤔

The file react-plain.svg itself does not exist, and if you try to access it directly, it won't work.
If you try to access that file even in the previous version (which had the icons working fine I believe), it won't work: https://cdn.jsdelivr.net/gh/devicons/devicon@v2.15.1/icons/react/react-plain.svg

@jeremygau
Copy link
Author

I don't think that these icons have ever existed in plain version.
For those that I am talking about, it is not a breaking change. I started to use them yesterday.

Perhaps I should not have report that as a bug
But as a request icon

The 403 error code misleaded me

@Panquesito7
Copy link
Member

Perhaps I should not have report that as a bug
But as a request icon

AFAIK, the icons you mentioned have aliases on other versions such as plain. See, for example, the react icon.

devicon/devicon.json

Lines 8624 to 8633 in 6910f05

"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]

@BalaM314
Copy link

1a35e2b this commit deletes the -plain version for Rust, the -plain icons did exist before

@lunatic-fox
Copy link
Contributor

As @jeremygau said it's not a breaking change (with some exceptions), however it's a feature that can be implemented to the project. I mean, since we have aliases to an icon it could fallback to the base icon or to a default icon.

One way that comes to my mind to solve this issue, like the case that @BalaM314 presented, is serving icons by an API. In other words, I could make another API like deviconapi that inherits the functionalities of the current one (which I prefer) or make big changes directly into deviconapi (which can possibly include some breaking changes).

The safest way to use the icons by now is using the devicon.dev site references.

That's weird but I think aliases weren't properly used at all in the project, just like tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs priority: high
Projects
None yet
Development

No branches or pull requests

5 participants