Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar doesn't display download/merge status for certain DASH downloads #106

Open
stabbedbybrick opened this issue Apr 26, 2024 · 1 comment

Comments

@stabbedbybrick
Copy link

Describe the bug
For certain DASH downloads, the progress bar doesn't display download or merge status and is stuck on LICENSED until the download is finished and it starts decrypting. It's still downloading and merging, but it doesn't display any progress.

Screenshots
licensed
download

If I use curl_impersonate as downloader, it does show the download status but incorrectly:

curl

Additional context
I'm getting this on multiple services, and so far the only common denominator I can find is that the progress bar will only display properly if the manifest is using a SegmentTimeline. Might just be a pure coincidence, though.

It's difficult to show with screenshots, so let me know if you want a video or something and I'll send it to you on discord.

@stabbedbybrick
Copy link
Author

A little follow up to this:

In requests.py, line 265, if I set segmented=False the progress bar comes back to life.

with ThreadPoolExecutor(max_workers=max_workers) as pool:
            for future in as_completed(
                pool.submit(
                    download,
                    session=session,
                    segmented=False,
                    **url
                )
                for url in urls

And the reason aria2c was also affected by this is because it doesn't support the Range header and falls back to requests downloader. So when I thought I was using aria, it was actually requests.

I know this isn't a solution, but it might give a clue as to what's causing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant