Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling broken with requests downloader #64

Open
k-santa opened this issue May 31, 2023 · 1 comment
Open

Cancelling broken with requests downloader #64

k-santa opened this issue May 31, 2023 · 1 comment
Labels
upstream Issue needs looking at by an upstream project dependency.

Comments

@k-santa
Copy link

k-santa commented May 31, 2023

Describe the bug
When using the requests downloader you can't cancel a download using Ctrl+C, the full download and decryption happens and then the cancel kicks in before multiplexing

To Reproduce
Set downloads: requests
Begin download and try and cancel

Expected behavior
We should see the STOPPING on the download process and a near immediate termination

@rlaphoenix
Copy link
Member

This is an issue more or less with the Python stdlib as explained in: psf/requests#5822

Therefore, there isn't realistically much that I can do about this unless I abstract the code to be run as it's own process (which will slow things down). This is because if I run it as a process via subprocess (i.e., subprocess.check_call(["python", "requests_downloader.py", "...args"])) then I can have CTRL+C fire as subprocess would take over there.

I will work on this soon and see if it's a truly viable option.

@rlaphoenix rlaphoenix added bug Something isn't working upstream Issue needs looking at by an upstream project dependency. labels Jan 16, 2024
@rlaphoenix rlaphoenix removed the bug Something isn't working label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue needs looking at by an upstream project dependency.
Projects
None yet
Development

No branches or pull requests

2 participants