Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planned Breaking changes for version 2.0.0 #98

Closed
6 tasks done
devsnd opened this issue Nov 5, 2020 · 3 comments
Closed
6 tasks done

Planned Breaking changes for version 2.0.0 #98

devsnd opened this issue Nov 5, 2020 · 3 comments
Labels
Milestone

Comments

@devsnd
Copy link
Owner

devsnd commented Nov 5, 2020

This is a record of planned breaking changes for a major version change

@devsnd
Copy link
Owner Author

devsnd commented Jul 2, 2022

Question from mathiascode: Should we keep exposing MP3, OGG etc interfaces directly, or only the TinyTag interface in the 2.0 release?

@mathiascode
Copy link
Collaborator

@devsnd I think we should mark the audio_offset variable as private. It's not available/used in several of our formats, and not very useful as-is without an additional variable like audio_size.

@mathiascode
Copy link
Collaborator

mathiascode commented Oct 26, 2023

Useful tool for upgrading syntax: https://github.com/asottile/pyupgrade

I'll create a new branch for 2.0.0 soon, which can eventually be merged into master. I see there are some previous branches that we could use as a starting point.

@mathiascode mathiascode pinned this issue Feb 28, 2024
@mathiascode mathiascode added this to the 2.0.0 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants