Added options object to be able to overwrite logging #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfederm
requested changes
Feb 3, 2020
|
|
||
| jasmineHtmlReporter: { | ||
| // Suppress failed messages (e.g. in combination with karma-mocha-reporter) | ||
| suppressFailed: true |
There was a problem hiding this comment.
I fear this will be copy/pasted even for people not using karma-mocha-reporter. Can you add a 2nd example specifically for karma-mocha-reporter to avoid this? Also, your reporters list doesn't actually list karma-mocha-reporter
There was a problem hiding this comment.
Yes you are correct, will do.
dfederm
approved these changes
Feb 3, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: In combination with 'karma-mocha-reporter' it is not possible to suppress the failure messages from 'karma-jasmine-html-reporter' completely. They would show up in between the nicely styled mocha-reporter.
Fix: added an options object for the karma config to suppress failure messages. This can be expanded with more settings if someone has a need.
Should be fully backward compatible.
Also updated the Readme.