Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose idb AUTH_DB_NAME and OBJECT_STORE_NAME constants #610

Closed
peterpeterparker opened this issue Aug 15, 2022 · 3 comments
Closed

Expose idb AUTH_DB_NAME and OBJECT_STORE_NAME constants #610

peterpeterparker opened this issue Aug 15, 2022 · 3 comments

Comments

@peterpeterparker
Copy link
Member

Feature request

It would be cool if both constants AUTH_DB_NAME and OBJECT_STORE_NAME from auth-client db.ts would be exposed for the consumer of the lib.

This is particularly interesting - for maintainability reason - for those who want to read the delegation and identity information that are saved in indexeddb.

@krpeacock
Copy link
Contributor

Can do! For fun, you can also just construct the IdbStorage interface with default options and get and set those values freely

@peterpeterparker
Copy link
Member Author

@krpeacock that's an excellent idea! I will try tomorrow, if it works it's way better than exposing the constant.

@peterpeterparker
Copy link
Member Author

@krpeacock indeed using IdbStorage in our web worker would work and therefore make this feature request unuseful.

Being said, while replacing our custom code in web worker with agent-js and this class, I noticed the two following issues for which I provided PRs:

Let me know if these make sense to you too. Once merged, it would be cool if you could release a new version because we will need such improvements to integrate the last version of agent-js in NNS-dapp PR #1247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants