Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate AssetManager Performance #636

Open
6 tasks
krpeacock opened this issue Oct 5, 2022 · 1 comment
Open
6 tasks

Evaluate AssetManager Performance #636

krpeacock opened this issue Oct 5, 2022 · 1 comment

Comments

@krpeacock
Copy link
Contributor

Describe the Issue
We reduced the upload size in #603 in order to get the tests to pass. Because large uploads will be a common use case for this tool, we should evaluate and benchmark various sizes of uploads in e2e tests in a browser and nodejs context

Instead of random bytes, we can also use some pre-existing assets with various file sizes - maybe a single image exported at different resolutions would be straightforward

Acceptance Criteria
Nodejs

  • 2mb(small upload)
  • 3mb(chunked upload)
  • 10mb(moderate upload)
    Browser
  • 2mb(small upload)
  • 3mb(chunked upload)
  • 10mb(moderate upload)
@sea-snake
Copy link
Contributor

sea-snake commented Oct 6, 2022

Larger asset tests were timing out due to #638. PR to increase asset sizes back to 1MB and 3MB: #639

I'll make another PR afterwards to add 10MB tests and browser tests. I would make a 1MB test instead of 2MB test so it doesn't get chunked (3MB and 10MB will).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants