Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console.log|warn|error has opt-in|out feature #843

Open
peterpeterparker opened this issue Feb 8, 2024 · 0 comments
Open

Console.log|warn|error has opt-in|out feature #843

peterpeterparker opened this issue Feb 8, 2024 · 0 comments

Comments

@peterpeterparker
Copy link
Member

peterpeterparker commented Feb 8, 2024

Is your feature request related to a problem? Please describe.

e.g. the function request of the agent warn in case of errors.

 console.warn(`Expected to find result for path ${path}, but instead found nothing.`);

While this might be hidden in a browser based environment, this can become annoying in a NodeJS environment when the caller handles the errors by themselves.

Concretely: in Juno CLI agent-js adds unexcepted outputs to the terminal.

Describe the solution you'd like
Any console output should be an opt-in or opt-out feature.

Side note:
Btw. I would even remove any information message (console.log) from the library for best performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant