From 0dd2a892e34c088b96b612b0d15f1dd534fb4e01 Mon Sep 17 00:00:00 2001 From: Linwei Shang Date: Tue, 22 Mar 2022 13:36:15 -0400 Subject: [PATCH 1/2] chore:add PR template --- .github/PULL_REQUEST_TEMPLATE.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..17f245a1b --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,15 @@ +# Description + +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. + +Fixes # (issue) + +# How Has This Been Tested? + +Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. + +# Checklist: + +- [ ] The title of this PR complies with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/). +- [ ] I have edited the CHANGELOG accordingly. +- [ ] I have made corresponding changes to the documentation. From 0b75a45d45170fe5cb593164d1f6f4e688771b54 Mon Sep 17 00:00:00 2001 From: Linwei Shang Date: Tue, 22 Mar 2022 13:17:29 -0700 Subject: [PATCH 2/2] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Kyle Peacock --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 17f245a1b..b3e2a4c4c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,6 +10,7 @@ Please describe the tests that you ran to verify your changes. Provide instructi # Checklist: +- [ ] My changes follow the guidelines in [CONTRIBUTING.md](https://github.com/dfinity/agent-js/blob/main/CONTRIBUTING.md). - [ ] The title of this PR complies with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/). - [ ] I have edited the CHANGELOG accordingly. - [ ] I have made corresponding changes to the documentation.