Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Arc<Type> with arc_type feature #407

Merged
merged 7 commits into from
May 23, 2023
Merged

Use Arc<Type> with arc_type feature #407

merged 7 commits into from
May 23, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jan 28, 2023

TODO: check if the docs.rs reflects the correct type

@github-actions
Copy link

Benchmark for dc6a19d

Click to view benchmark
Test Base PR %
Blob/&str 220.9±129.29µs 200.9±118.99µs -9.05%
Blob/ByteBuf 132.5±49.50µs 134.2±49.62µs +1.28%
Blob/Bytes 101.6±46.24µs 102.5±47.82µs +0.89%
Blob/String 238.2±129.55µs 238.7±130.18µs +0.21%
Collections/vec (text, nat) 66.6±0.75ms 68.5±0.91ms +2.85%
Collections/vec int 29.9±0.10ms 31.4±0.15ms +5.02%
Collections/vec int64 16.2±0.14ms 27.0±0.22ms +66.67%
Collections/vec nat8 13.3±0.03ms 23.9±0.01ms +79.70%
option list/1024 1348.5±1.55µs 1540.3±1.98µs +14.22%
profiles/1024 2.5±0.03ms 3.0±0.00ms +20.00%
variant list/1024 1110.2±2.33µs 1309.2±8.61µs +17.92%

@github-actions
Copy link

Benchmark for c0a6718

Click to view benchmark
Test Base PR %
Blob/&str 266.6±84.03µs 268.5±82.56µs +0.71%
Blob/ByteBuf 176.1±49.59µs 177.4±52.54µs +0.74%
Blob/Bytes 119.2±36.76µs 118.6±35.22µs -0.50%
Blob/String 287.1±91.40µs 284.8±90.07µs -0.80%
Collections/vec (text, nat) 81.2±2.56ms 85.2±2.72ms +4.93%
Collections/vec int 35.9±0.65ms 37.0±0.93ms +3.06%
Collections/vec int64 21.4±0.56ms 32.2±1.05ms +50.47%
Collections/vec nat8 16.1±0.28ms 26.3±0.56ms +63.35%
option list/1024 1506.3±39.84µs 1801.8±34.90µs +19.62%
profiles/1024 2.9±0.07ms 3.4±0.06ms +17.24%
variant list/1024 1200.4±22.78µs 1489.7±16.45µs +24.10%

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

Benchmark for b708bde

Click to view benchmark
Test Base PR %
Blob/&str 233.2±107.22µs 234.6±109.80µs +0.60%
Blob/ByteBuf 155.1±45.34µs 154.3±45.42µs -0.52%
Blob/Bytes 112.3±41.20µs 109.6±43.23µs -2.40%
Blob/String 299.4±145.42µs 267.3±120.77µs -10.72%
Collections/vec (text, nat) 71.8±1.31ms 71.2±1.13ms -0.84%
Collections/vec int 31.6±0.13ms 31.8±0.09ms +0.63%
Collections/vec int64 18.4±0.28ms 19.5±0.25ms +5.98%
Collections/vec nat8 14.1±0.05ms 14.0±0.02ms -0.71%
option list/1024 1380.1±2.12µs 1375.0±2.78µs -0.37%
profiles/1024 2.6±0.01ms 2.6±0.01ms 0.00%
variant list/1024 1117.9±5.42µs 1126.5±6.78µs +0.77%

@chenyan-dfinity chenyan-dfinity changed the title Change Rc<Type> to Arc<Type> Use Arc<Type> with arc_type feature May 21, 2023
@github-actions
Copy link

Benchmark for 9040674

Click to view benchmark
Test Base PR %
Blob/&str 245.6±72.83µs 241.3±72.64µs -1.75%
Blob/ByteBuf 163.7±43.98µs 174.2±42.00µs +6.41%
Blob/Bytes 115.2±33.48µs 122.5±30.25µs +6.34%
Blob/String 245.8±67.82µs 249.8±69.28µs +1.63%
Collections/vec (text, nat) 72.0±0.97ms 72.2±1.23ms +0.28%
Collections/vec int 31.7±0.08ms 31.8±0.09ms +0.32%
Collections/vec int64 19.1±0.31ms 18.6±0.23ms -2.62%
Collections/vec nat8 14.1±0.04ms 14.2±0.05ms +0.71%
option list/1024 1388.4±4.93µs 1381.3±2.15µs -0.51%
profiles/1024 2.6±0.00ms 2.6±0.01ms 0.00%
variant list/1024 1119.6±3.48µs 1115.4±2.59µs -0.38%

@chenyan-dfinity chenyan-dfinity merged commit eb31f88 into master May 23, 2023
@chenyan-dfinity chenyan-dfinity deleted the arc branch May 23, 2023 21:34
@github-actions
Copy link

Benchmark for 9c437df

Click to view benchmark
Test Base PR %
Blob/&str 276.1±90.34µs 270.6±81.35µs -1.99%
Blob/ByteBuf 228.1±63.50µs 221.8±66.02µs -2.76%
Blob/Bytes 153.8±35.06µs 141.6±35.34µs -7.93%
Blob/String 329.3±88.59µs 333.8±88.78µs +1.37%
Collections/vec (text, nat) 92.0±3.67ms 89.3±5.46ms -2.93%
Collections/vec int 40.0±1.26ms 40.3±2.55ms +0.75%
Collections/vec int64 24.2±0.82ms 23.6±1.03ms -2.48%
Collections/vec nat8 17.7±0.74ms 17.8±0.89ms +0.56%
option list/1024 1765.8±68.45µs 1750.0±89.55µs -0.89%
profiles/1024 3.3±0.17ms 3.3±0.17ms 0.00%
variant list/1024 1393.3±61.50µs 1383.3±63.22µs -0.72%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants