Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom candid path for export_service #421

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

chenyan-dfinity
Copy link
Contributor

  • support custom candid path for export_service

@github-actions
Copy link

Benchmark for 110664d

Click to view benchmark
Test Base PR %
Blob/&str 301.2±159.98µs 298.1±148.46µs -1.03%
Blob/ByteBuf 223.2±57.41µs 227.1±61.85µs +1.75%
Blob/Bytes 167.1±64.30µs 161.7±64.50µs -3.23%
Blob/String 365.5±155.80µs 364.6±159.86µs -0.25%
Collections/vec (text, nat) 91.8±5.35ms 88.3±4.94ms -3.81%
Collections/vec int 40.0±2.12ms 40.2±1.24ms +0.50%
Collections/vec int64 22.4±1.72ms 22.2±1.14ms -0.89%
Collections/vec nat8 16.7±0.81ms 16.4±0.70ms -1.80%
option list/1024 1790.2±210.50µs 1748.9±67.12µs -2.31%
profiles/1024 3.4±0.13ms 3.3±0.14ms -2.94%
variant list/1024 1434.8±63.92µs 1406.7±53.18µs -1.96%

@chenyan-dfinity chenyan-dfinity changed the title Misc fixes for integration with Rust CDK support custom candid path for export_service May 23, 2023
@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review May 23, 2023 21:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

Benchmark for 392a828

Click to view benchmark
Test Base PR %
Blob/&str 300.9±146.39µs 299.8±158.01µs -0.37%
Blob/ByteBuf 227.8±59.74µs 228.0±61.58µs +0.09%
Blob/Bytes 167.7±59.93µs 161.9±58.48µs -3.46%
Blob/String 371.7±162.78µs 369.6±175.01µs -0.56%
Collections/vec (text, nat) 95.6±3.17ms 94.4±2.79ms -1.26%
Collections/vec int 41.9±1.01ms 41.1±1.61ms -1.91%
Collections/vec int64 23.4±1.12ms 23.1±1.30ms -1.28%
Collections/vec nat8 17.8±0.55ms 17.5±0.59ms -1.69%
option list/1024 1849.8±29.46µs 1839.6±51.92µs -0.55%
profiles/1024 3.5±0.07ms 3.5±0.14ms 0.00%
variant list/1024 1438.7±52.43µs 1433.1±43.78µs -0.39%

@chenyan-dfinity chenyan-dfinity merged commit b9d6cbf into master May 23, 2023
@chenyan-dfinity chenyan-dfinity deleted the misc-fix branch May 23, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants