PdoException leakage - API encapsulation breakage

[jkuchar]

Version: 3.1.1

Bug Description

When I configure dibi to use existing PDO connection which has configured to throw exceptions instead of throwing warnings, encapsulations is broken.

Steps To Reproduce

// pseudocode
$pdoConnection->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
$dibiConnection = Dibi::connect(["driver"=>"pdo", "connection" => $pdoConnection]);
try {
  $dibiConnection->exec("WHAT EVER WITH ERROR IN IT");
} catch (Dibi\DriverException $e) {
  echo "catched";
} 

output:

Fatal error: unhandled exception ...

Expected Behavior

try {
  $dibiConnection->exec("WHAT EVER WITH ERROR IN IT");
} catch (Dibi\DriverException $e) {
  echo "catched";
} 

output:

catched
exited (0)

Possible Solution

a. Throw exception in dibi::connect() if misconfigured PDO connection is provided.
b. Wrap connection into proxy which reconfigures temporarily connection when used by dibi (can has ugly side effects)
c. Catch exceptions in Dibi code alongside with classic error handling (increases dibi internal code complexity)

I would prefer to go with a) as it fails fast, it is simple to implement and does not have any side effects.

[dg]

I would prefer to go with a) in 4.0.x & 3.2.x and c) for 4.1.0.

Can you implement it?

[jkuchar]

Will try to propose something.

[jkuchar]

I have created two PRs, consider them as drafts, feedback is welcome.

[dg]

Thanks!