[Bug] Docker container "restarting (132)" with image 0.45.18 or higher

[Nekrotza]

Describe the bug
Image "ghcr.io/dgtlmoon/changedetection.io:0.45.18" or higher causes container status "Restarting (132)".

Version
Works fine until version 0.45.17

To Reproduce
Update from a previous version or a new clean install causes same output.
The hardware is an old Intel Celeron P4600 (2) @ 2GHz with 8GB of RAM.
The Host OS is Debian GNU/Linux 11 (bullseye) x86_64.

The logs are empty.

[Tor4nkusu]

Same here.
Ubuntu 22.04.4 LTS
Upgraded from 0.45.17 to 0.45.20 and docker image is stuck on "Restarting (132)"

[dgtlmoon]

"The Host OS" which VM solution are you using?

[Nekrotza]

Sorry, maybe i expressed myself wrong, i'm not using a VM.

[Tor4nkusu]

"The Host OS" which VM solution are you using?

I'm on Server 2016 w/ HyperV hosting that ubuntu VM.

[dgtlmoon]

hmm a quick google shows me other projects have the same issue, i have no solution or dont really even know where to start

so if anyone has any ideas... :)

[rklos]

Hi, I have the same problem on a dedicated server (no virtualisation) with Ubuntu 22.04.4 LTS and Docker 26.0.2.

edit:
Downgrading to Docker 25 didn't change anything, so it's not a problem with new major Docker release.

[Constantin1489]

Is this relevant? https://bugs.launchpad.net/lxml/+bug/2063343

[dgtlmoon]

Interesting, nice find!

…

On 27 April 2024 15:58:59 UTC, Constantin Hong ***@***.***> wrote: Is this relevant? https://bugs.launchpad.net/lxml/+bug/2063343 -- Reply to this email directly or view it on GitHub: #2328 (comment) You are receiving this because you were assigned. Message ID: ***@***.***>

[0xuser]

I have the same problem, I switched back to version 0.45.17.

[dgtlmoon]

https://bugs.launchpad.net/lxml/+bug/2059910 it looks like there was some changes to lxml and the minimum level of hardware has changed... it is compiled with some instructions that require a more modern CPU

this fits our pattern - the problem seems to affect people with older CPUs

[Constantin1489]

This is follow-up: https://bugs.launchpad.net/lxml/+bug/2059910/comments/16

[dgtlmoon]

This is follow-up: https://bugs.launchpad.net/lxml/+bug/2059910/comments/16

Excellent, so it means lxml 5.2.2 ?

what about this syntax for the requirements.txt?

# 5.2.0 and 5.2.1 had bad CPU flags set causing a crash
lxml >=4.8.0,<6, !=5.2.0, !=5.2.1

[Constantin1489]

looks good!

python3.12 -m pip uninstall lxml && python3.12 -m pip install lxml==5.2.0 && python3.12 -m pip install -r req.txt

[Constantin1489]

Ah forgot this too. So works

[dgtlmoon]

looks good!

@Constantin1489 since 5.2.0/5.2.1 have the extra CFLAGs for better performance on newer CPUs, any chance you can run some of your wonderful speed/benchmark tests on 5.1.9 vs 5.2.0 ?

I'm curious exactly how much faster it is

other thing, would be nice if there was a lxml[modern] pip package where this stuff was set too.. worth asking the maintainer?

[Constantin1489]

With this shell script, and let's say the file is data/reddit.html

(python3.12 -m pip uninstall lxml -y && python3.12 -m pip install lxml==5.1.1) > /dev/null 2>/dev/null
python3.12 <<EOF
import timeit
setup_code = """
from lxml import etree, html
parser = etree.HTMLParser()
with open('data/reddit.html', 'rb') as f:
    html_bytes = f.read()
"""
code = """
html.fromstring(html_bytes, parser=parser)
"""
print(timeit.timeit(setup=setup_code, stmt=code, number=1000))
EOF

(python3.12 -m pip uninstall lxml -y && python3.12 -m pip install lxml==5.2.0) > /dev/null 2>/dev/null
python3.12 <<EOF
import timeit
setup_code = """
from lxml import etree, html
parser = etree.HTMLParser()
with open('data/reddit.html', 'rb') as f:
    html_bytes = f.read()
"""
code = """
html.fromstring(html_bytes, parser=parser)
"""
print(timeit.timeit(setup=setup_code, stmt=code, number=1000))
EOF

result was

$python3.12 -c 'print((16.555711069027893 - 16.908115033991635)/ 16.908115033991635  * 100)'
-2.0842297574583437

the difference between 5.1.9 and 5.2.0 is so 2%? I'm not that math savvy...

For two.. I don't know..