Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing from the sdist doesn't work #34

Open
xhochy opened this issue Jan 30, 2024 · 0 comments · May be fixed by #35
Open

Installing from the sdist doesn't work #34

xhochy opened this issue Jan 30, 2024 · 0 comments · May be fixed by #35

Comments

@xhochy
Copy link

xhochy commented Jan 30, 2024

I'm currently in the process of packaging this into a conda-forge package. There, we prefer to build/install from the sdist on PyPI. Sadly, this runs into the following hurdles:

  1. better-setuptools-git-version doesn't work with Python>=3.10
  2. It actually assumes that it always runs from within a git repository. This is not the case for an sdist. Alternatives like setuptools-scm thus place the "rendered" version into the static metadata.

I'll propose to move to setuptools-scm like most other packages using setuptools and git versioning have done. I'm going to open a PR, but wanted to give more context here first.

@xhochy xhochy linked a pull request Jan 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant