From 3b88aa0125da346a864d730bbe6da7c6edb6e928 Mon Sep 17 00:00:00 2001 From: Daniel Nalborczyk Date: Wed, 20 Sep 2023 16:50:44 -0400 Subject: [PATCH] refactor: re-activate unicorn/no-useless-promise-resolve-reject --- .eslintrc.cjs | 1 - src/lambda/LambdaFunction.js | 2 +- src/lambda/handler-runner/docker-runner/DockerContainer.js | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 2a449e7b7..93db86e01 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -71,7 +71,6 @@ module.exports = { 'unicorn/no-null': 'off', 'unicorn/no-static-only-class': 'off', 'unicorn/no-unreadable-array-destructuring': 'off', - 'unicorn/no-useless-promise-resolve-reject': 'off', 'unicorn/no-useless-undefined': 'off', 'unicorn/prefer-module': 'off', 'unicorn/prefer-spread': 'off', diff --git a/src/lambda/LambdaFunction.js b/src/lambda/LambdaFunction.js index 9ec27b356..1de0383e6 100644 --- a/src/lambda/LambdaFunction.js +++ b/src/lambda/LambdaFunction.js @@ -250,7 +250,7 @@ export default class LambdaFunction { entries(zip.files).map(async ([filename, jsZipObj]) => { const fileData = await jsZipObj.async('nodebuffer') if (filename.endsWith('/')) { - return Promise.resolve() + return undefined } await ensureDir(join(this.#codeDir, dirname(filename))) return writeFile(join(this.#codeDir, filename), fileData, { diff --git a/src/lambda/handler-runner/docker-runner/DockerContainer.js b/src/lambda/handler-runner/docker-runner/DockerContainer.js index 83ab35b55..d7b3f8b44 100644 --- a/src/lambda/handler-runner/docker-runner/DockerContainer.js +++ b/src/lambda/handler-runner/docker-runner/DockerContainer.js @@ -313,7 +313,7 @@ export default class DockerContainer { entries(zip.files).map(async ([filename, jsZipObj]) => { const fileData = await jsZipObj.async('nodebuffer') if (filename.endsWith(sep)) { - return Promise.resolve() + return undefined } await ensureDir(join(layerDir, dirname(filename))) return writeFile(join(layerDir, filename), fileData, {