From c996a944fe4c795470b603a750ef6f645f80dd88 Mon Sep 17 00:00:00 2001 From: Daniel Nalborczyk Date: Mon, 8 Jul 2019 08:55:06 -0400 Subject: [PATCH] Use constant for base url placeholder --- src/ApiGatewayWebSocket.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ApiGatewayWebSocket.js b/src/ApiGatewayWebSocket.js index a53c8dbda..58490abaf 100644 --- a/src/ApiGatewayWebSocket.js +++ b/src/ApiGatewayWebSocket.js @@ -13,6 +13,11 @@ const { createUniqueId, parseQueryStringParameters } = require('./utils'); const authFunctionNameExtractor = require('./authFunctionNameExtractor'); const wsHelpers = require('./websocketHelpers'); +// dummy placeholder url for the WHATWG URL constructor +// https://github.com/nodejs/node/issues/12682 +// TODO move to common constants file +const BASE_URL_PLACEHOLDER = 'http://example'; + module.exports = class ApiGatewayWebSocket { constructor(serverless, options) { this.serverless = serverless; @@ -171,7 +176,7 @@ module.exports = class ApiGatewayWebSocket { only: true, initially: false, connect: ({ ws, req }) => { - const { searchParams } = new URL(req.url, `ws://${req.headers.host}`); + const { searchParams } = new URL(req.url, BASE_URL_PLACEHOLDER); const queryStringParameters = parseQueryStringParameters( searchParams, );