Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: randomly generated API key is not displayed if no API key is defined #1067

Closed
kdybicz opened this issue Aug 22, 2020 · 1 comment

Comments

@kdybicz
Copy link
Contributor

kdybicz commented Aug 22, 2020

Bug Report

I found out that there is a regression of a fix done for a bug from few months ago #832

Current behavior

I don't want to copy whole description, all details are in linked original issue, but the main and most important line of its description says:

If we have a service that defines http events as private: true, but not define apiKeys, the generated API key is not logged.

Expected behavior

A better solution would be to check if there are any http events with private: true.

Environment

  • serverless version: 1.77.1
  • serverless-offline version: 6.4.0
  • node.js version: 14.8.0
  • OS: macOS 10.15.6

Workaround

provider:
  apiKeys: []

Possible Solution

Pull request with proposed fix: #1066

@kdybicz
Copy link
Contributor Author

kdybicz commented Aug 28, 2020

Was merged and released in v6.6.0

@kdybicz kdybicz closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant