New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-canvas fails after updating 6.7.0 => 6.8.0 #1112
Comments
Do you have a sample of how you are using it? |
Minimal reproduction project at https://github.com/tomyam1/slss-offline-1112 Waths weird is that in the minimal project, serverless-offline version 6.6.0 works and versions 6.7.0 and 6.8.0 don't. |
I'll need to look further, but it looks like it due to a non javascript module being unloaded. |
Did you ever figure this issue out? Every change to any serverless function results with "Module did not self-register" error. It's not a fun dev env when you need to restart the server and wait a minute every time you hit save. Thanks |
Yes |
Closing this becaus it's a duplicate of #871 |
Bug Report
After updating
6.7.0
to6.8.0
I get the following error after requiring https://github.com/Automattic/node-canvasThis is
bindings.js:3:
https://github.com/Automattic/node-canvas/blob/v2.6.1/lib/bindings.js#L3I suspect this is due to #1091
Maybe it doesn't clear the module cache correctly?
@dl748 Since you made the commit, can you please take a look?
Locking version at 6.7.0 (without changing anything else) prevents the issue
Environment
serverless
version: 1.83.0serverless-offline
version: 6.8.0node.js
version: 12.13.0OS
: [e.g. macOS 10.13.4, Windows 10, Ubuntu 16.04]The text was updated successfully, but these errors were encountered: