[Bug] Fix issue with incorrect 0 -> '' conversion in HTTP responses #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If invokeResults.Payload === 0, then it was replaced by empty string, which caused buggy behavior. Example case: We have a lambda that returns a number of upvotes for a post. So, when it returned 0, then HTTP response contained '' (empty string) instead.
medikoo
reviewed
Feb 11, 2022
|
@trsrm there's a CLI fail related to file formatting. Can you fix that? |
medikoo
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
invokeResults.Payload === 0, then it gets replaced by empty string'', which causes buggy behavior in many cases.Motivation and Context
How Has This Been Tested?
Manual testing (nothing should be broken).
Screenshots (if appropriate):
Screenshot