Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use go build command instead of go run command #1356

Merged
merged 1 commit into from May 11, 2022

Conversation

uh-zz
Copy link
Contributor

@uh-zz uh-zz commented Mar 21, 2022

Description

When launching Go's lambda, use go build command instead of go run command to run the binary file.

Motivation and Context

I was looking for a way other than using --useDocker before and came up with the following issue.

#1334

Also, I found and commented on pull requests to add the feature to do local launches without --useDocker

#1320 (comment)

go build command alows you to import and use all packages including main, so you can use not only a single main.go, but also separate packages.

@dherault
Copy link
Owner

Thanks @uh-zz ! Note: tests are failing.

@uh-zz
Copy link
Contributor Author

uh-zz commented Apr 17, 2022

@dherault
Thanks reply! I fixed error in the test (npm run prettier-check:updated), please check again!

Copy link
Owner

@dherault dherault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's see if the tests are passing.

@dnalborczyk
Copy link
Collaborator

thank you @uh-zz !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants