Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hapi v18 #657

Closed
wants to merge 6 commits into from
Closed

hapi v18 #657

wants to merge 6 commits into from

Conversation

hueniverse
Copy link
Contributor

Closes #634

This is a bit ugly and I'm not sure how well the tests cover the code, but it should at least get you going.

@dherault
Copy link
Owner

Hi @hueniverse, thanks for takling this huge subject! Can you make the CI green please?

@dnalborczyk
Copy link
Collaborator

I think it's only the package-lock.json missing.

@hueniverse
Copy link
Contributor Author

There you go.

@dherault
Copy link
Owner

@dnalborczyk do you want to become a maintainer of the plugin ?

@dherault
Copy link
Owner

Sorry I merged another PR that led to conflicting files... @hueniverse

@hueniverse
Copy link
Contributor Author

This was a one time merge resolution... ;-) Next one is someone else's problem.

@dnalborczyk
Copy link
Collaborator

dnalborczyk commented May 16, 2019

@dherault just gave the PR a spin, node-only, with an itself hapi-backend, as well as an apollo-graphql-lambda backend, working flawless on both! tested with node v12.2.0.

you might want to do a semver major release, as this PR (or better, hapi v18) will require node.js v8 minimum, which is also the new minimum with AWS anyways.

do you want to become a maintainer of the plugin ?

sure, I'll help out!

@dherault
Copy link
Owner

dherault commented Jun 2, 2019

Closed in favor of #679
Still your work @hueniverse
Thank you and @dnalborczyk !

@dherault
Copy link
Owner

dherault commented Jun 2, 2019

v5.0.0 🎉 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARN deprecated hapi@16.7.0
3 participants