Fix server start handling (callback -> promise) #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherault
requested changes
Jun 2, 2019
| // TODO FIXME | ||
| // should we just write the error to console and exit? | ||
| console.error('Unexpected error in serverless-offline.', e); | ||
| process.exit(1); |
There was a problem hiding this comment.
'Unexpected error while starting serverless-offline server:' would be more verbose.
Otherwise I think logging the error and exiting 1 is correct.
Please remove the comments
|
v5.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #683
hapi server callback is now a promise. not quite sure about the error handling recommendation. (console.error, process.exit) previously the callback error being wrapped in a promise was not being handled down the chain as far as I could tell (might have missed it).