Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept content type json with empty body #694

Merged
merged 4 commits into from Jun 7, 2019
Merged

Accept content type json with empty body #694

merged 4 commits into from Jun 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2019

Closes #566

@ghost ghost marked this pull request as ready for review June 6, 2019 14:50
@ghost ghost changed the title Updated package-lock Accept content type json with empty body Jun 6, 2019
@ghost
Copy link
Author

ghost commented Jun 6, 2019

Created this PR because of no response from @purefan in #566 . I want this as I also want same kind of behaviour.

@dherault
Copy link
Owner

dherault commented Jun 6, 2019

Hello @sulaysumaria, please make the CI green and I'll review :)

@ghost
Copy link
Author

ghost commented Jun 6, 2019

The error in CI build is following:

Using NVS for managing Node.js versions on Windows (BETA)
21.21s$ git clone --single-branch https://github.com/jasongin/nvs $NVS_HOME
From https://github.com/dherault/serverless-offline
 * branch            refs/pull/694/merge -> FETCH_HEAD
Cloning into 'C:\ProgramData/nvs'...
The command "git clone --single-branch https://github.com/jasongin/nvs $NVS_HOME" failed and exited with 128 during .
Your build has been stopped.
fatal: unable to access 'https://github.com/jasongin/nvs/': Failed to connect to github.com port 443: Timed out

I believe thats not a code issue. Can you trigger the build again?
Also only one of the windows build is failing with this error. Rest all builds are passed.

@dherault

@ghost
Copy link
Author

ghost commented Jun 7, 2019

@dherault, all checks passing.

@dherault dherault merged commit bd65e02 into dherault:master Jun 7, 2019
@dherault
Copy link
Owner

dherault commented Jun 7, 2019

v5.1.1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants