Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.6.0 is not working properly with Python #730

Closed
Rafaelsk opened this issue Jul 4, 2019 · 5 comments
Closed

Version 5.6.0 is not working properly with Python #730

Rafaelsk opened this issue Jul 4, 2019 · 5 comments

Comments

@Rafaelsk
Copy link

Rafaelsk commented Jul 4, 2019

After updating to version 5.6.0 of serverless-offline it loads correctly my functions paths (rest api handlers), but when I invoke them (through Postman) the actual handlers are never invoked, it just returns 200 and null as the response body.

We downgraded to a previous version and it works well again.

Here is the serverless.yml file for the test:

service: test

#frameworkVersion: ">=1.1.0 <2.0.0"
provider:
  name: aws
  runtime: python3.6
functions:
  ola:
    handler: todos/list.list
    events:
      - http:
          path: ola
          method: get
plugins:
  - serverless-offline

And here is the handler code (python):

import json

def list(event, context):
    response = {
        "statusCode": 200,
        "body": json.dumps('Was ist passiert?')
    }
    return response
@dnalborczyk
Copy link
Collaborator

thanks @Rafaelsk ! I guess we missed to test python 😕

@Rafaelsk
Copy link
Author

Rafaelsk commented Jul 4, 2019

@dnalborczyk I'm glad to know I could help.

@Rafaelsk Rafaelsk changed the title Version 5.6.0 is not working properly Version 5.6.0 is not working properly with Python Jul 4, 2019
dnalborczyk added a commit that referenced this issue Jul 4, 2019
@dnalborczyk
Copy link
Collaborator

@Rafaelsk I was under the assumption that v5.6.0 broke your environment, but it seems this bug has been lingering around for a while.

I just reverted a commit which broke the functionality. should be fixed with the next release. (note: there still seems to be a timeout issue.)

from npm: I fairly safe version to use should be v5.4.2 (until master is released)

@dherault
Copy link
Owner

dherault commented Jul 6, 2019

v5.6.1

@Rafaelsk
Copy link
Author

Rafaelsk commented Jul 9, 2019

@dnalborczyk Alright. Thanks. I'll try again on the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants