fix: missing base in URL() constructor

[frsechet]

As req.url only contains the relative URL, the base URL parameter (or absolute input URL, either of those must be given) was missing from the new URL(req.url) call, which causes a crash on $connect action as it is unable to parse the query string parameters and throws with ERR_INVALID_URL.

[dnalborczyk]

hey @frsechet thank you! you are right.

that being said, I believe req.headers.host is also not guaranteed to exist, as it is a header.

there are many discussions about this topic of a replacement and the deprecation of [now legacy] url.parse.

in the meantime, I think the suggested option is to use a "dummy" base url: nodejs/node#12682 , e.g. http://www.example.com

[dherault]

v5.7.2 🎉

[vinchi777]

Getting

TypeError: Cannot convert undefined or null to object
serverless-offline/src/ApiGatewayWebSocket.js:199

This kinda fixed it
if (queryStringParameters && Object.keys(queryStringParameters).length > 0)