Error when processing responseParameters

[jormaechea]

There is a bug (a typo, probably) when processing response parameters.

See this line of code:

serverless-offline/src/ApiGateway.js

Line 639 in 88fecc4

Object.entries(responseParametersKeys).forEach(

It should be Object.entries(responseParameters).

[jormaechea]

Great @dnalborczyk! Is the release scheduled or something? 🤔

[dnalborczyk]

Is the release scheduled or something? 🤔

@jormaechea

released as part of v6.0.0-alpha.0: https://github.com/dherault/serverless-offline/releases/tag/v6.0.0-alpha.0

[jormaechea]

Uhmm, ok.. Can't this two bug fixes be released to v5 also? So we can keep using a stable version without the bugs?
We can't afford to use an alpha version at the office..

Thanks!!

[dnalborczyk]

@jormaechea

So we can keep using a stable version without the bugs?

who says an alpha version has to have bugs? 😃

We can't afford to use an alpha version at the office..

I wouldn't look too closely at the semantics. we mainly chose an alpha pre-release for the following reasons: the code base has been (and is going to be) refactored, and it's hard to guarantee the same behavior as in the v5.x branch, as there's unfortunately a bit of of tests lacking (which hopefully will improve eventually). so essentially we are signaling: hey, keep an eye out, stuff might be broken. the other reason is also that it gives us the opportunity for some breaking changes, if needed. (e.g. right now, the timeout feature has been removed, but will be reimplemented)

Can't this two bug fixes be released to v5 also?

Originally I didn't plan to maintain 2 release branches, but I included your 2 PRs in v5.9.0 https://github.com/dherault/serverless-offline/releases/tag/v5.9.0

That being said, it would be great if you could give the alpha release branch a try as well. if you discover any unforeseen bugs, you could just report them, and switch back to v5.x.

[jormaechea]

who says an alpha version has to have bugs? 😃

LOL!

Thanks for releasing v5.9.0!
I'll give a test drive to the v6 alpha in some side projects for sure, and will get back to you if I find something.

I'm happy to colaborate with this great project! 🚀
Let me know if you need some help ;)