Do not remove unhandledRejection listeners as it breaks Serverless #767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
unhandledRejection
listener currently breaks exit code handling in Serverless 1.48.1+ -> serverless/serverless#6441, it technically turns off some important part of Serverless logic.Serverless no longer forces process exit on
unhandledRejection
, so merging this in won't introduce a regression to #255 (which also should rather have been processed in context ofserverless
repo, not here)In future Serverless may force process exit on
unhandledRejection
but only if there were no listeners registered for it, which is on pair with Node.js deprecation warning: