Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not reloaded on websockets endpoints #909

Closed
ricardovf opened this issue Feb 26, 2020 · 4 comments
Closed

Code not reloaded on websockets endpoints #909

ricardovf opened this issue Feb 26, 2020 · 4 comments

Comments

@ricardovf
Copy link

Bug Report

Current Behavior

Websockets works as expected. If i change the code and send a new message using wscat, the returned message is the same, even if the code seems to be loaded again...

Sample Code

https://github.com/ricardovf/example-serverless-ws-offline-not-reloading

@dherault
Copy link
Owner

@ricardovf
Copy link
Author

ricardovf commented Mar 24, 2020

You did not read the instructions on the readme to reproduce...

"change the "hi" on the code to "hi 1" and send again the {"action": "default"} and you will not see the updated code"

The point is that a code change is not reloading the handler, although it maintains the websocket connection opened.

If we could use hot reload with typescript + serverless-offline it would be really great..

@dherault
Copy link
Owner

Why not use a tool like nodemon?

@ricardovf
Copy link
Author

ricardovf commented Mar 25, 2020

Im, but it's slow compared to hotreload because it gotta compile all TS, start serverless offline and init the server... Im using websockets (api gateway), sns, etc. I mean, it works, but for a fluid dev env, it could be faster.

I guess my issue is related to: #864 and #931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants