Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extract util for generating hapiPath #994

Merged
merged 1 commit into from May 28, 2020
Merged

refactor: Extract util for generating hapiPath #994

merged 1 commit into from May 28, 2020

Conversation

chardos
Copy link
Collaborator

@chardos chardos commented May 28, 2020

Purpose

In my previous PR I noticed there was some duplicate logic for generating paths in createRoutes and createResourceRoutes.

Have extracted this code to a utility so any future updates can happen in one place.

@dherault
Copy link
Owner

Thanks @chardos!
On your third PR you'll be asked if you want to become a maintainer ;)

@dherault dherault merged commit 3ca8048 into dherault:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherault dherault dherault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chardos @dherault