Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noPrependStageInUrl false should have a leading slash #946

Merged
merged 5 commits into from Apr 1, 2020
Merged

noPrependStageInUrl false should have a leading slash #946

merged 5 commits into from Apr 1, 2020

Conversation

dl748
Copy link
Contributor

@dl748 dl748 commented Mar 31, 2020

No description provided.

@dl748
Copy link
Contributor Author

dl748 commented Mar 31, 2020

@dherault can you check my test, I'm not sure if its where you want the test

@dl748
Copy link
Contributor Author

dl748 commented Mar 31, 2020

Fixes #945

Copy link
Owner

@dherault dherault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I left some thoughts

status: 200,
},

// TODO: reactivate!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment these lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want me to remove the comments?

Copy link
Contributor Author

@dl748 dl748 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only copied it from above as a duplicate, but i removed the comments

status: 200,
},

// TODO: reactivate!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want me to remove the comments?

@dherault dherault merged commit 36414e3 into dherault:master Apr 1, 2020
@dherault
Copy link
Owner

dherault commented Apr 1, 2020

v6.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants