Fix: serverless-offline crashes if a function definition does not have a handler #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erverless-offline set up an event handler.
dherault
approved these changes
May 5, 2020
This was referenced May 25, 2021
1 task
This was referenced Jun 23, 2021
1 task
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the existence of a handler property before trying to have serverless-offline set up an event handler. It's possible to have mock integrations configured in API Gateway via serverless framework that have no handler and always return a static response. My team has and is using these in production, but serverless-offline cannot handle them right now.
This fix prevents serverless-offline from crashing, but it still warns
WARNING: Entry for my-function-without-handler@undefined could not be retrieved.I can provide a full example serverless.yml that triggers this bug if requested.
https://serverless.com/framework/docs/providers/aws/events/apigateway/#mock-integration