Also support --disableCookieValidation when we createResourceRoutes.
#975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__This should close dherault#974 by forward porting my v5 solution from https://github.com/dherault/serverless-offline/pull/863__. Requests to `resourceRoutes` created behind an API Gateway Proxy (i.e., running with `--resourceRoutes`) would fail due to hapi just exploding on the cookie validation. This just rips off the strategy in dherault#513 (specifically dherault@5d9a67a) and dherault#863 Much of the credit here goes to @cassiohub (@cassiohubner on GitLab).
dherault
approved these changes
May 5, 2020
randytarampi
deleted the
fix/support-disabling-cookie-validation-on-resource-routes
branch
This was referenced May 25, 2021
1 task
This was referenced Jun 23, 2021
1 task
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #974 by forward porting my v5 solution from #863.
Requests to
resourceRoutescreated behind an API Gateway Proxy (i.e., running with--resourceRoutes) would fail due to hapi just exploding on the cookie validation.This just rips off the strategy in #513 (specifically 5d9a67a) and #863
Much of the credit here goes to @cassiohub (@cassiohubner on GitLab).