Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scaling for high-DPI monitors #67

Open
dhowland opened this issue Apr 2, 2018 · 3 comments
Open

Implement scaling for high-DPI monitors #67

dhowland opened this issue Apr 2, 2018 · 3 comments

Comments

@dhowland
Copy link
Owner

dhowland commented Apr 2, 2018

The current GUI includes several hard-coded pixel sizes that will not look right on a 4k monitor.

@dhowland dhowland self-assigned this Apr 2, 2018
@dhowland dhowland added this to the 3.0 milestone Apr 2, 2018
@dhowland
Copy link
Owner Author

dhowland commented Apr 7, 2018

I tried to test 4k today by using Nvidia DSR to double my screen resolution. It didn't work. I have no way to test this, so the Issue is going to have to wait. :(

@dhowland dhowland modified the milestones: 3.0, 3.2 Apr 14, 2018
@gorauskas
Copy link

gorauskas commented Apr 14, 2018

This is what it looks like on a Seiki 4K tv at 30 Hz that I use as a monitor. DPI is set to 96. This is Arch Linux with XFCE 4.12

image

Does this help in anyway? ... or are you testing for something different?

@dhowland
Copy link
Owner Author

Wow this is really great feedback. Thank you very much.

The GUI is written in such a way that a 1u key is 48x48 pixels. That looks good on my 1080p screen, but the assumption was that on a 4K screen the buttons would be too small. On a high DPI screen the text is usually scaled to remain readable, thus the size of the buttons should also be scaled.

The screenshots you've provided don't show that, but you also aren't using a high-DPI screen. Regular HD monitors are usually around 100 DPI and 4K are usually around 200 DPI. So your TV is so large that the DPI is actually about the same as an HD monitor, so I still need more research.

This whole thing is complicated because the OS can usually perform automatic DPI scaling. I don't know how that would affect the tool.

Oh well. If there is a problem, eventually someone will show up complaining about the interface, and I can fix it then.

@dhowland dhowland removed this from the 3.2 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants