Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ESLint #1

Open
Azkali opened this issue Jan 10, 2020 · 5 comments
Open

Update to ESLint #1

Azkali opened this issue Jan 10, 2020 · 5 comments

Comments

@Azkali
Copy link

Azkali commented Jan 10, 2020

TSLint -> ESLint

Issue Description

As TSLint is in deprecation state you should port this repo to ESLint.

Possible resolution

Using the npm package tslint-to-eslint-config you should be able to easily port your config to ESLint, I can make a PR if you wish !

@GerkinDev
Copy link
Member

I tested the package you mention, and it does not support all options of tslint. Moreover, beware, it tends to forget to append plugins.

OK for a PR, but make a different file for eslint & do not move the tslint config. While eslint for typescript is not in a better state, both should coexist.

@Azkali
Copy link
Author

Azkali commented Jan 11, 2020

Will do so !

@Azkali
Copy link
Author

Azkali commented Jan 11, 2020

Or maybe I can create a new branch for ESLint ( + TSLint rules not supported by ESLint ).

I find this better than polluting the main branch ( user could want TSLint only ) and also ESLint can have his own version ( package.json )

@Azkali Azkali closed this as completed Jan 11, 2020
@Azkali Azkali reopened this Jan 11, 2020
@GerkinDev
Copy link
Member

I don't see the problem with 2 config files at root level. This would pollute with a single file, and otherwise, it would drastically complexify versioning & releases for such a simple repo...

@Azkali
Copy link
Author

Azkali commented Jan 12, 2020

Alright, I will follow your lead then !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants